fix: R_FindPlane aborts on visplane pool exhaustion - #162
Conversation
- R_FindPlane calls i_error! on visplane pool exhaustion instead of returning null Fixes sunsided#117 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| @@ -547,7 +548,7 @@ pub extern "C" fn R_ClearPlanes() { | |||
| /// and light level 0. | |||
| /// | |||
| /// Returns a null pointer if the visplane pool (128 entries) is exhausted | |||
There was a problem hiding this comment.
WARNING: Stale doc comment — function no longer returns null on exhaustion
The function now aborts via i_error! when the visplane pool is exhausted, but this doc comment still claims it returns a null pointer. Update to reflect the actual behavior (e.g., "Aborts via i_error! if the visplane pool (128 entries) is exhausted").
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
There was a problem hiding this comment.
Fixed in 6ea8c18 — doc now states abort via crate::i_error! on visplane pool exhaustion (no longer claims null return).
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Previous WARNING on Files Reviewed (1 file)
Previous Review Summary (commit 15c8a44)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 15c8a44)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (1 file)
Reviewed by kimi-k2.6 · Input: 39.9K · Output: 1.4K · Cached: 68.7K |
1 participant
Summary
R_FindPlane aborts on visplane pool exhaustion
Changes
Fixes #117