fix(server): hide mutating stdio tools in read-only mode fixes #281#323
Closed
ahfoysal wants to merge 2 commits into
Closed
fix(server): hide mutating stdio tools in read-only mode fixes #281#323ahfoysal wants to merge 2 commits into
ahfoysal wants to merge 2 commits into
Conversation
Member
|
Hey! Thank you for your contribution! I was actually reviewing #283, which seems to fix the same core issue as #281. That other PR adds something I particularly like: the fact that write tools are still registered, and it returns a nicer error when in read mode, e.g., "Cannot apply migration in read-only mode." This PR seems to remove that altogether, which I think provides a less-than-ideal UX. I appreciate your contribution, though, so please keep them coming! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createSupabaseMcpServerfilters tools before registration when--read-onlyis enabled.readOnlyHint: falsein read-only mode, sotools/listno longer exposes mutating actions.execute_sql) that remain visible with adjusted annotations.Verification
CI=1 ./node_modules/.bin/vitest run --project integration test/stdio.integration.tsCloses #281