fix(seed-rich-telemetry): validate services count#253
Open
suryapratapsingh26 wants to merge 1 commit into
Open
fix(seed-rich-telemetry): validate services count#253suryapratapsingh26 wants to merge 1 commit into
suryapratapsingh26 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Validate the
--servicesCLI argument before using it.Previously, passing a non-numeric value (for example
--services abc) causedNumber()to returnNaN, which propagated throughMath.max/Math.minand resulted in an invalid service count. This change validates the parsed value and throws an error for invalid input.Addresses item #12 from Code Audit issue #68.
How to test
Run:
Verify the script exits with:
Run:
Verify the script starts normally.
AI assistance
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm formathas been run on changed filesmainworker: …,fix(slack): …)Summary by cubic
Validate the --services CLI argument in scripts/demo/seed-rich-telemetry.ts to prevent NaN-based invalid service counts (addresses Code Audit issue #68, item 12). Non-numeric or infinite values now throw "invalid services count"; valid numbers are floored and clamped to 1–8.
Written for commit 601ed3d. Summary will update on new commits.