Skip to content

fix: surface search hit titles in recall injections - #99

Open
ayushsingh82 wants to merge 1 commit into
supermemoryai:mainfrom
ayushsingh82:fix/recall-title-94
Open

fix: surface search hit titles in recall injections#99
ayushsingh82 wants to merge 1 commit into
supermemoryai:mainfrom
ayushsingh82:fix/recall-title-94

Conversation

@ayushsingh82

Copy link
Copy Markdown
Contributor

Summary

  • resultText()/formatRecall() in recall-directive.js rendered memory/chunk text and filepath but dropped the title field the API already returns on search hits — the only thing distinguishing similar-looking results.
  • Recalled lines now prefix with Title: when a title is present, matching the format used before the CLI-free restructure.

Ports the idea from #88 (closed as stale after the #71 refactor removed plugin/scripts/), reopened as #94.

Test plan

  • node --test test/unit.mjs — all 23 tests pass, including an added assertion covering a titled search hit

resultText()/formatRecall() in recall-directive.js only rendered
memory/chunk text and filepath, dropping the title field the API
already returns on search hits — the only thing distinguishing
similar-looking results. Prefix recalled lines with "Title: " when
a title is present, matching the format used elsewhere.

Ports the idea from supermemoryai#88, tracked as supermemoryai#94.
@ayushsingh82

Copy link
Copy Markdown
Contributor Author

@Dhravya PR is up — resubmitting the recall-title idea from #88 against the new CLI-free architecture, closes #94.

@ayushsingh82

Copy link
Copy Markdown
Contributor Author

@Dhravya heads up — the claude-review job is failing with "Could not fetch an OIDC token", not because of anything in this diff. That's GitHub Actions restricting id-token/secrets on pull_request-triggered runs from forks; the workflow's id-token: write permission doesn't apply to fork PRs. Might be worth switching that job to pull_request_target (with the usual checkout-pin caution) or gating it behind a maintainer-triggered event if you want it to run on external contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant