Skip to content

fix(browser-extension): guard project name against null textContent #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Agnik47 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(browser-extension): guard project name against null textContent #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Install dependencies
run: bun install --frozen-lockfile

- name: Detect SDK and playground changes
- name: Detect SDK, playground and browser extension changes
id: sdk-changes
run: |
if git diff --quiet "${{ github.event.pull_request.base.sha }}" HEAD -- packages/tools; then
Expand All @@ -47,6 +47,12 @@ jobs:
echo "sdk_playground=true" >> "$GITHUB_OUTPUT"
fi

if git diff --quiet "${{ github.event.pull_request.base.sha }}" HEAD -- apps/browser-extension; then
echo "browser_extension=false" >> "$GITHUB_OUTPUT"
else
echo "browser_extension=true" >> "$GITHUB_OUTPUT"
fi

- name: Setup Python for SDK Playground
if: steps.sdk-changes.outputs.sdk_playground == 'true'
uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
Expand Down Expand Up @@ -98,6 +104,10 @@ jobs:
if: steps.sdk-changes.outputs.sdk_playground == 'true'
run: bun run --cwd apps/sdk-playground build:app

- name: Run Browser Extension type checking
if: steps.sdk-changes.outputs.browser_extension == 'true'
run: bun run --cwd apps/browser-extension check-types

- name: Run Memory Graph type checking
run: bun run --cwd packages/memory-graph check-types

Expand Down
2 changes: 1 addition & 1 deletion apps/browser-extension/utils/ui-components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ export function createProjectSelectionModal(
if (selectedOption.value) {
const selectedProject = {
id: selectedOption.value,
name: selectedOption.textContent,
name: selectedOption.textContent ?? "",
containerTag: selectedOption.dataset.containerTag || "",
}
onImport(selectedProject)
Expand Down
Loading