fix(memory-graph): enable touch and mobile node dragging and interaction - #1639
Open
Adityakk9031 wants to merge 1 commit into
Open
fix(memory-graph): enable touch and mobile node dragging and interaction#1639Adityakk9031 wants to merge 1 commit into
Adityakk9031 wants to merge 1 commit into
Conversation
Contributor
Author
|
Hey @Dhravya @MaheshtheDev, could you please take a look at this fix when you have a moment? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
packages/memory-graph/src/canvas/input-handler.ts, desktop mouse interaction (onMouseDown) tests the spatial index (this.spatialIndex.queryPoint) to detect when a node is clicked or dragged.However, touch interaction (
onTouchStart) unconditionally initiated a canvas pan (this.isPanning = true) for single touches without querying the spatial index for a node hit. Consequently:Solution
onTouchStartto querythis.spatialIndex.queryPoint(startWorld.x, startWorld.y)before defaulting to panning. If a node is hit, it setsthis.draggingNode = nodeand invokesonNodeDragStart(node.id, node)while disabling viewport panning.onTouchMoveto reposition the activedraggingNode(fx,fy,x,y) and request canvas re-renders when a node is being dragged on touch.onTouchEndto clear fixed drag coordinates (fx/fy), resetdraggingNode, and fireonNodeDragEnd().touchStartNodeIdat touch start so tap-to-select cleanly triggersonNodeClickupon tap release without interference from sub-threshold finger jitter.packages/memory-graph/src/__tests__/input-handler-touch.test.tsverifying node dragging on touch, viewport panning on empty space, and tap selection.Verification
Ran
bun test packages/memory-graph/src/__tests__/input-handler-touch.test.ts(all 8 tests passed).