fix: preserve paths.base when vite preview redirects a prerendered page to the correct trailing slash - #16836
Merged
Merged
Conversation
…ge to the correct trailing slash
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/9764887370a7f7d35cdea1325435557c92d01615Open in |
🦋 Changeset detectedLatest commit: 9764887 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trailing-slash redirect for prerendered pages in
exports/vite/preview/index.jswrites an absolutelocationfrom the pathname the middleware sees, but that middleware runs insidescoped(base, ...), which has already strippedpaths.base. With a base path the browser lands on/nested/instead of/base/nested/. Production (#9351) and adapter-node (#16431) send a relative location for this reason and use 308; preview now does the same viarelative_pathname.