Skip to content

chore: give scroll and focus their own state and tests - #16983

Open
Nic-Polumeyv wants to merge 1 commit into
client-focus-modulefrom
client-focus-design
Open

chore: give scroll and focus their own state and tests#16983
Nic-Polumeyv wants to merge 1 commit into
client-focus-modulefrom
client-focus-design

Conversation

@Nic-Polumeyv

@Nic-Polumeyv Nic-Polumeyv commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

On top of #16980: scroll.js owns the after-navigation scroll and focus.js owns the blur and the focus reset, with finish_navigation the one place that sequences them. Whether the app moved focus during the update is now read from document.activeElement directly instead of a snapshot taken before the update, and a navigation that does not reset no longer scrolls to where it already is.

A focused SVG element is now blurred before the DOM update like any HTML element.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 31, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 889a452:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/889a45281340aad710c21b4dc98d002cb5f11b43

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16983

@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 889a452

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e22b5f56-4e2a-4f2a-95e7-72534d784ab3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant