fix: externalize linked dependencies when loading explicit env - #16988
Draft
svelte-triage-bot[bot] wants to merge 1 commit into
Draft
fix: externalize linked dependencies when loading explicit env#16988svelte-triage-bot[bot] wants to merge 1 commit into
svelte-triage-bot[bot] wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/9975cd45fa3d88fca55ac3aaf6ba92e6096f8627Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 9975cd4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16987.
The isolated Vite server used to evaluate
src/env.tsexternalized installeddependencies but inlined linked workspace dependencies. This caused linked
packages to bypass native Node execution and prevented Node loader hooks from
resolving their imports.
Configure the isolated server with
ssr.external: trueso linked and installeddependencies use consistent native Node semantics.
A regression test creates a linked package with an import resolved by a Node
loader hook and verifies that explicit environment loading succeeds.
Verification:
@sveltejs/kitunit suiteoptions-2production buildpnpm checkpnpm lint