Skip to content

BridgeJS: fix code generation for public enums #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kateinoigakukun merged 1 commit into from
Apr 14, 2026
Merged

BridgeJS: fix code generation for public enums #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Plugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ struct EnumCodegen {
)
printer.nextLine()

printer.write("private init?(bridgeJSRawValue: Int32) {")
printer.write("@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {")
printer.indent {
printer.write("switch bridgeJSRawValue {")
for (index, enumCase) in enumDef.cases.enumerated() {
Expand All @@ -984,7 +984,7 @@ struct EnumCodegen {
printer.write("}")
printer.nextLine()

printer.write("private var bridgeJSRawValue: Int32 {")
printer.write("@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {")
printer.indent {
printer.write("switch self {")
for (index, enumCase) in enumDef.cases.enumerated() {
Expand Down
4 changes: 2 additions & 2 deletions Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/ArrayTypes.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ extension Direction: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .north
Expand All @@ -27,7 +27,7 @@ extension Direction: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .north:
return 0
Expand Down
4 changes: 2 additions & 2 deletions ...idgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/DefaultParameters.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ extension Status: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .active
Expand All @@ -25,7 +25,7 @@ extension Status: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .active:
return 0
Expand Down
4 changes: 2 additions & 2 deletions ...geJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/EnumAssociatedValue.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ extension CardinalDirection: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .north
Expand All @@ -218,7 +218,7 @@ extension CardinalDirection: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .north:
return 0
Expand Down
16 changes: 8 additions & 8 deletions Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/EnumCase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ extension Direction: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .north
Expand All @@ -27,7 +27,7 @@ extension Direction: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .north:
return 0
Expand Down Expand Up @@ -55,7 +55,7 @@ extension Status: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .loading
Expand All @@ -68,7 +68,7 @@ extension Status: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .loading:
return 0
Expand All @@ -94,7 +94,7 @@ extension TSDirection: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .north
Expand All @@ -109,7 +109,7 @@ extension TSDirection: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .north:
return 0
Expand Down Expand Up @@ -137,7 +137,7 @@ extension PublicStatus: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .success
Expand All @@ -146,7 +146,7 @@ extension PublicStatus: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .success:
return 0
Expand Down
8 changes: 4 additions & 4 deletions ...eJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/EnumNamespace.Global.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ extension Networking.API.Method: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .get
Expand All @@ -27,7 +27,7 @@ extension Networking.API.Method: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .get:
return 0
Expand Down Expand Up @@ -61,7 +61,7 @@ extension Internal.SupportedMethod: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .get
Expand All @@ -72,7 +72,7 @@ extension Internal.SupportedMethod: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .get:
return 0
Expand Down
8 changes: 4 additions & 4 deletions ...s/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/EnumNamespace.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ extension Networking.API.Method: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .get
Expand All @@ -27,7 +27,7 @@ extension Networking.API.Method: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .get:
return 0
Expand Down Expand Up @@ -61,7 +61,7 @@ extension Internal.SupportedMethod: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .get
Expand All @@ -72,7 +72,7 @@ extension Internal.SupportedMethod: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .get:
return 0
Expand Down
4 changes: 2 additions & 2 deletions Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/Protocol.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ extension Direction: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .north
Expand All @@ -648,7 +648,7 @@ extension Direction: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .north:
return 0
Expand Down
4 changes: 2 additions & 2 deletions ...S/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/StaticFunctions.Global.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ extension Calculator: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .scientific
Expand All @@ -23,7 +23,7 @@ extension Calculator: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .scientific:
return 0
Expand Down
4 changes: 2 additions & 2 deletions ...BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/StaticFunctions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ extension Calculator: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .scientific
Expand All @@ -23,7 +23,7 @@ extension Calculator: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .scientific:
return 0
Expand Down
4 changes: 2 additions & 2 deletions .../Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/StaticProperties.Global.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ extension PropertyEnum: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .value1
Expand All @@ -23,7 +23,7 @@ extension PropertyEnum: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .value1:
return 0
Expand Down
4 changes: 2 additions & 2 deletions ...ridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/StaticProperties.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ extension PropertyEnum: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .value1
Expand All @@ -23,7 +23,7 @@ extension PropertyEnum: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .value1:
return 0
Expand Down
4 changes: 2 additions & 2 deletions ...ns/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/SwiftClosure.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,7 +1280,7 @@ extension Direction: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .north
Expand All @@ -1295,7 +1295,7 @@ extension Direction: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .north:
return 0
Expand Down
8 changes: 4 additions & 4 deletions Tests/BridgeJSGlobalTests/Generated/BridgeJS.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ extension GlobalNetworking.API.CallMethod: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .get
Expand All @@ -36,7 +36,7 @@ extension GlobalNetworking.API.CallMethod: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .get:
return 0
Expand Down Expand Up @@ -70,7 +70,7 @@ extension Internal.SupportedServerMethod: _BridgedSwiftCaseEnum {
return bridgeJSLowerParameter()
}

private init?(bridgeJSRawValue: Int32) {
@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
switch bridgeJSRawValue {
case 0:
self = .get
Expand All @@ -81,7 +81,7 @@ extension Internal.SupportedServerMethod: _BridgedSwiftCaseEnum {
}
}

private var bridgeJSRawValue: Int32 {
@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
switch self {
case .get:
return 0
Expand Down
2 changes: 1 addition & 1 deletion Tests/BridgeJSRuntimeTests/ExportAPITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ extension Greeter {

// MARK: - Enum Tests

@JS enum Direction {
@JS public enum Direction {
case north
case south
case east
Expand Down
Loading
Loading