test: add reviewer v0.4 antagonist specs#7
Closed
laynepenney wants to merge 1 commit into
Closed
Conversation
4 tasks
laynepenney
added a commit
that referenced
this pull request
May 8, 2026
…gainst None JudgingReviewer now clamps adapter scores to [0.0, 1.0] at the bridge layer, preventing out-of-range scores from propagating through reviewer chains. HallucinationSignalRule now skips verdicts with score=None instead of raising TypeError. Closes #7 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spec Status
This PR is intentionally red-by-design.
Targeted slice result:
python -m pytest -q tests/unit/test_reviewer.py tests/unit/test_judge.py tests/unit/test_suggestion_engine.py104 passed, 3 failedruff check tests/unit/test_reviewer.py tests/unit/test_judge.py tests/unit/test_suggestion_engine.pypassesIntended red seams:
JudgingReviewerdoes not clamp out-of-range adapter scores at the bridgeJudgingReviewerdoes not clamp negative adapter scores at the bridgeHallucinationSignalRuledoes not handlescore=NonesafelyBoundary
eval#1category-scoping remains a separate slice and is not folded into this PR