Skip to content

fix: align TOS padding with iOS#903

Open
jvsena42 wants to merge 4 commits intomasterfrom
fix/tos-polish
Open

fix: align TOS padding with iOS#903
jvsena42 wants to merge 4 commits intomasterfrom
fix/tos-polish

Conversation

@jvsena42
Copy link
Copy Markdown
Member

@jvsena42 jvsena42 commented Apr 23, 2026

This PR polishes the Terms of Use onboarding screen to match bitkit-ios and align with the next screen (Intro).

Description

  1. Increases the top spacer above the "Terms of use" header from 16dp to 48dp, matching iOS's .padding(.top, 48) so the heading has the same breathing room below the status bar
  2. Reduces the footer bottom padding from 24dp to 16dp so the Continue button sits 16dp above the navigation bar inset — identical to the Get Started / Skip Intro buttons on the following Intro screen, preventing the visual jump when advancing through onboarding

The Scaffold's contentPadding already provides the systemBars inset (Android equivalent of iOS safe area), so no structural changes were needed.

Preview

android.webm
android-nav-bar.webm
ios.mp4

QA Notes

  1. Launch a fresh onboarding flow and open the Terms of Use screen
    • Verify the "Terms of use" header has visible breathing room below the status bar (larger than before)
    • Verify the scrollable TOS content starts below the header as expected
  2. Scroll to the bottom of the TOS content and tap Continue
    • Verify the Continue button sits close to the navigation bar area with a 16dp gap
    • Verify there is no vertical jump when transitioning to the Intro screen — the Continue button position should match the Get Started / Skip Intro buttons
  3. Test on a device with gesture navigation and a device with 3-button navigation
    • Verify the button respects the system bar inset on both (no overlap with nav bar, no excess whitespace)
  4. Verify the TermsPreview still renders correctly in Android Studio

@jvsena42 jvsena42 self-assigned this Apr 23, 2026
@jvsena42 jvsena42 enabled auto-merge April 23, 2026 12:13
@jvsena42 jvsena42 requested a review from ovitrif April 23, 2026 12:13
Comment thread app/src/main/java/to/bitkit/ui/onboarding/TermsOfUseScreen.kt Outdated
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 24, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant