fix: align top bar arrow and passphrase with ios#906
Open
fix: align top bar arrow and passphrase with ios#906
Conversation
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
ic_arrow_leftdrawable inAppTopBar, matching the iOS arrow glyph#FF4400) cursor color to the shared text field defaults, aligning every text field with the iOSbrandAccenttintOutlinedTextFieldon the Create Wallet With Passphrase screen for the sharedTextInputwrapper so the placeholder renders in Inter Tight Semi-Bold + White64 like iOSDescription
Icons.AutoMirrored.Default.ArrowBack. The new vector drawable matches the line/chevron proportions used on iOS across every screen that mountsAppTopBar.OutlinedTextFielddirectly. Swapping toTextInputis consistent with the Restore Wallet passphrase/mnemonic inputs, and picks up Inter Tight Semi-Bold + White64 placeholder styling automatically.AppTextFieldDefaults.semiTransparent), so every text field in the app now renders a brand-orange cursor — intentionally universal, because iOS appliesbrandAccentvia its sharedTextFieldcomponent rather than per-screen.Preview
ios.mp4
android.webm
QA Notes
#FF4400), not the Material default purpleAppTopBar(Settings, Transfer, Activity detail)AppTextFieldDefaults.semiTransparent(Restore Wallet mnemonic and passphrase inputs, settings text fields)./gradlew compileDevDebugKotlinclean./gradlew detektclean