Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds configurable pathfinding scorer parameters so apps can tune routing behavior instead of always using LDK defaults.
It introduces two new config surfaces:
ScoringFeeParameters(maps toProbabilisticScoringFeeParameters)ScoringDecayParameters(maps toProbabilisticScoringDecayParameters)These can now be set through:
Config(scoring_fee_params,scoring_decay_params)BuilderAPIs:set_scoring_fee_params(...)set_scoring_decay_params(...)At build time, ldk-node now uses configured scorer params when constructing/deserializing the
ProbabilisticScorerand router fee params, falling back to LDK defaults when unset.Why this is needed
Probe and payment outcomes are sensitive to scorer behavior (penalty model + decay dynamics). With hardcoded defaults, consumers cannot adapt routing to their environment (e.g., aggressive probing diversity vs conservative reliability). This change makes scorer behavior explicit