Fix NoMethodError when email domain is nil#53
Open
tnantoka wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, and thanks for this great gem. I've been using it happily for years.
After the change in #42, some of my accounts started getting a
NoMethodError(
undefined method 'casecmp?' for nil) on login. It turned out that someMicrosoft accounts (personal ones, in my case) don't return a
mail, soemail_domainbecomes nil andcasecmp?raises before the other checks areevaluated, even with
skip_domain_verificationset.I fixed it with safe navigation, so a missing email simply does not match by
domain and falls through to the existing skip / JWT claim / error paths.
I saw #17 (comment) and I understand this gem isn't really aimed at personal accounts,
but since this change has no real downside (org accounts behave exactly the
same), I would be glad if you could consider merging it.
Thanks again!