fix(governance): auto-reconcile pending receipts on the background poll

[sidhujag]

Problem

After submitting a vote, the per-proposal cohort chip (e.g. Voted 1/10) and the "Last N votes" activity-card badges sat on their pre-confirm state (Pending / Submitted) indefinitely. The user had to navigate into a proposal (which reopened its vote modal and implicitly triggered a reconcile via useOwnedMasternodes) and then come back to the Governance page before any relayed → confirmed transition surfaced.

Root cause: GET /gov/receipts/summary is documented as a pure SELECT — no RPC, no reconciliation — and POST /gov/receipts/reconcile (the only path that flips receipts from relayed to confirmed via gobject_getcurrentvotes) was only fired when the modal opened. The 30s Governance background poll only refetched the pure-read summary, so stale relayed rows never got touched.

Fix

The background poll in useGovernanceReceipts now runs a reconcile sweep before each summary refetch:

1. Scan the last-known summary (read through a ref so the callback identity stays stable and useBackgroundPoll doesn't reset its cadence on every state change) for proposals with relayed > 0.
2. Fan out governanceService.reconcileReceipts(hash) in parallel. Promise.allSettled so one flaky proposal can't stall the sweep.
3. Call load() to surface any transitions the reconciles just wrote.

RPC cost

Bounded by three existing backend layers, no new server-side work needed:

• Route-level freshness check in /gov/receipts/reconcile short-circuits with reconciled: false (no RPC) when every row for a proposal is already confirmed inside receiptsFreshnessMs.
• currentVotesCache (2 min TTL) collapses concurrent gobject_getcurrentvotes calls across all logged-in users to one RPC per proposal per TTL window.
• POST /gov/vote already invalidates that cache for the just-voted proposal, so the first post-relay reconcile hits the chain cleanly instead of returning a stale snapshot.

What stays the same

• /gov/receipts/summary stays pure — only the client sweep issues reconciles.
• refresh() (called by Governance.closeVoteModal) stays pure. useOwnedMasternodes already reconciled the just-voted proposal when the modal opened, so closeVoteModal doesn't need to fan out again. Guarded by a dedicated test.
• GovernanceActivity's independent 30s poll is untouched — it reads the same DB the sweep just updated, so badges flip on its next tick.
• Feature-detected: services without reconcileReceipts degrade to a plain load (legacy test fixtures keep passing — dedicated test).

Test plan

5 new tests added in useGovernanceReceipts.test.js:

• A background tick fires reconcile for every proposal with relayed > 0 and re-loads /summary to surface relayed → confirmed transitions.
• A background tick with no relayed rows skips reconcile entirely and only re-loads /summary.
• A reconcile failure on one proposal does not stop the remaining reconciles or the follow-up load.
• enabled=false suppresses the background sweep so anonymous / gated-off sessions never issue reconcile RPC.
• A service stub without reconcileReceipts still polls /summary cleanly (back-compat).

Plus one guard on the existing surface:

• Manual refresh() does NOT fire reconcile — reconciliation belongs only to the background cadence so modal-close doesn't double up on the RPC the vote modal already issued.

Verified locally

• useGovernanceReceipts.test.js — 17/17 pass.
• Governance.test.js, GovernanceOpsHero.test.js, GovernanceActivity.test.js, ProposalVoteModal.test.js — 105/105 pass combined across all governance-related suites.
• No lint errors.

After deploy

Submit a vote, leave the Governance page open. Within ~30s the cohort chip on that proposal row should flip from Pending to Voted X/Y, and the activity card should flip its badge from Submitted to On-chain — no page reload, no navigation required.

Made with Cursor