Attachments stage 2b: retire the inert browser expiry worker#220
Merged
Conversation
The server-side sweep (stage 2) owns attachment expiry now, so remove the old browser path it replaced: - drop the attachment_expiry unit from the supervisor (loop/manager/worker), which now walks six units instead of seven; - delete src/lib/agents/attachment_expiry/; - remove SupabaseService.expireOldAttachments and the expire_old_attachments RPC (schema keeps an idempotent `drop function` so a sync clears it from any project that ran the earlier schema); - delete tests/attachment-expiry-loop.test.ts; - refresh the comments that enumerated attachment_expiry as a live worker. It was already inert post-stage-1 (the RPC matched zero rows after the base64 reclaim), so this is pure cleanup. Gate green: svelte-check 0, lint, knip, 1764 tests, build clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SYNOPSIS
Remove the inert browser attachment-expiry worker now that the server-side sweep (stage 2) owns expiry.
DESCRIPTION
Stage 2 moved attachment expiry to a server-side cron + edge function. The old browser path it replaced was already a no-op post-stage-1 (its RPC nulled
data where data is not null, which matches zero rows after the base64 reclaim). Remove it:attachment_expiryunit from the supervisor (loop/manager/worker) - it now walks six units, not seven, and theattachmentExpiryDaystunable is gone.src/lib/agents/attachment_expiry/.SupabaseService.expireOldAttachmentsand theexpire_old_attachmentsRPC (schema keeps an idempotentdrop functionso a sync clears it from any project that ran the earlier schema).tests/attachment-expiry-loop.test.ts; refresh the comments that listedattachment_expiryas a live worker.Pure cleanup. Gate green: svelte-check 0 errors, lint, knip, 1764 tests, build clean.
Generated by Claude Code