feat(THI-52): modernize results tab

[tdody]

Summary

Rebuilds the Results tab (1400 → 2088 lines, most of the growth from splitting the monolith into named helper components) around the THI-45/46 design system. Introduces two new shared primitives and restyles every section around tokens.

New primitives

• shared/SensitivityCard.tsx — labeled card wrapping an SVG line chart with accent stroke, token-colored axes, dashed zero line. Takes {label,value}[] plus optional yLabel: "$" | "%".
• shared/ExpenseBreakdown.tsx — stacked horizontal bar + legend. Sorts breakdown descending, assigns distinct oklch colors per slice, shows each category's $ and % in the legend.

Headline strip (3-col)

Per the ticket: Annual Cashflow (emphasis=large serif), IRR (from irr_with_exit when projections are loaded, else projections' operating IRR), Break-even Occupancy with warn tone above 70%. Followed by two secondary strips covering Cash-on-Cash, Cap Rate, DSCR, NOI, Gross Yield, Year-1 ROI, After-Tax Monthly, Guest Cost per Night.

10-year projection table with inline bars

ProjectionTable helper — each row's Cashflow cell now renders a thin horizontal bar below the value, width proportional to |value| / max, colored accent for positive and negative for negative. All existing columns preserved (Gross / NOI / Cashflow / Cum CF / CoC / Value / Balance / Equity / After-tax).

Sensitivity

• STR occupancy + rate sweeps → two <SensitivityCard> in a 2-col grid
• LTR vacancy + rent (in the comparison section) → same primitive
• Hold-period IRR sweep → SensitivityCard with yLabel="%"

Expense breakdown

STR and LTR expense sections now use <ExpenseBreakdown> for a stacked bar + legend, paired with a compact housing-costs mini-table on the right.

Other modernization

• Every MetricCard usage → MetricCell / MetricStrip
• Warnings (DSCR, occupancy, rental delay) → internal WarnBanner / InfoBanner helpers using warn / accent tokens
• All collapsibles (tax analysis, monthly cashflow, projections + exit, amortization, STR↔LTR comparison) → shared Disclosure helper with caret + serif title
• MonthlyCashflowChart rewritten to use token colors and JetBrains Mono axis labels
• Scenario selector uses the same bottom-rule select style as the Financing tab's loan-type picker, plus a caps pill for rental type
• All indigo / violet / sky / emerald / amber / red / slate classes removed

Preserved behavior

• Data fetching unchanged (getResults / getResultsForScenario / getLTRResults / getSensitivity / getLTRSensitivity / getAmortization / getProjections / getMonthlyBreakdown)
• Scenario selector, STR↔LTR comparison, monthly breakdown, exit analysis, hold-period sweep, amortization, depreciation, tax analysis all still present and fetched on-demand via collapsibles
• ResultsTab prop interface unchanged

Test plan

• npm run lint — clean
• npm run build — passes, CSS 52.09 kB, JS 454.97 kB (-9 kB), 118 modules
• Dev run, STR: headline strip populates from active scenario, secondary strips match prior values; sensitivity cards render in 2-col grid
• Dev run, STR: expand Projections → see the 10-year table with inline bars; expand Exit Analysis nested inside
• Dev run, LTR: headline strip shows Annual CF / Cap / DSCR; expense breakdown renders; amortization expands
• Dev run, STR: expand Compare STR vs LTR → table highlights the winner per row; LTR sensitivity cards render
• Dark mode: all strips, tables, sensitivity charts, stacked bar, warnings swap tokens correctly

🤖 Generated with Claude Code