Add pygraspa backend for ML-potential GCMC#13
Merged
Conversation
Adds a new matkit.pygraspa backend that produces simulation directories ready to run with pygRASPA (https://github.com/tdpham2/pygRASPA), which runs gRASPA Monte Carlo with ML interatomic potentials (FAIRChem, MACE-Polar, Allegro) instead of classical force fields. API mirrors matkit.graspa: setup_simulation, setup_batch, get_output_data, plus a compute_ecomp helper for the per-adsorbate reference energy that pygRASPA needs for the Metropolis criterion. Setup-only integration - matkit writes a run.py launcher into each sim dir and does not import pygRASPA or torch at install time, so the new package adds no GPU dependencies to matkit itself. Includes single + batch setup, single/mixture isotherm orchestrator, matkit pygraspa CLI commands, and a no-GPU pytest suite covering the template rendering, batch manifest, and JSON-lines log parser.
Add pygraspa backend for ML-potential GCMC
Drop an unused ase.io.write import and rename the ambiguous `l` loop variable (E741) in test_utils.py, and wrap the long assertion in test_batch_writes_mapping_only_for_renamed (E501).
Brings the two new files into line with the rest of src/ so `ruff format --check src/` passes in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What's in here
Modes supported
Test plan