Jeff 551 - #644
Open
Jeff-Stammler wants to merge 3 commits into
Open
Conversation
Moved all of the dataFile classes up a level (got them out of the Utility folder) now that ALL of them use this method - no need to put them under utility. Added .csv files for Accuracy, ClimbPosition and ClimbLevel. Added dataFile classes for all three, and then fixed up any references to them to be consistent with the other dataFile classes. (getAccuracyValue -> getAccuracyId [for example]). Simplified how we display the Loading... messages using a parameterized string rather than having double strings (loading vs error). Fixed logic in PostMatch for detecting if all fields are filled in. Before, we logged a few things then did some checks (which leaves partial logged data - which didn't cause an issue, but didn't make sense (and used more memory). Also when checking the ClimbPosition and ClimbLevel, only check IF the components are ENABLED (meaning the robot climbed and we need a choice). Otherwise ignore it. Not sure how that worked correctly before if the robot didn't climb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved all of the dataFile classes up a level (got them out of the Utility folder) now that ALL of them use this method - no need to put them under utility.
Added .csv files for Accuracy, ClimbPosition and ClimbLevel. Added dataFile classes for all three, and then fixed up any references to them to be consistent with the other dataFile classes. (getAccuracyValue -> getAccuracyId [for example]).
Simplified how we display the Loading... messages using a parameterized string rather than having double strings (loading vs error).
Fixed logic in PostMatch for detecting if all fields are filled in. Before, we logged a few things then did some checks (which leaves partial logged data - which didn't cause an issue, but didn't make sense (and used more memory). Also when checking the ClimbPosition and ClimbLevel, only check IF the components are ENABLED (meaning the robot climbed and we need a choice). Otherwise ignore it. Not sure how that worked correctly before if the robot didn't climb.
fixed some compiler warnings and grammar issues (android studio reports these now!)
fixes #551