Skip to content

Chi 3295 formdef package move#2962

Merged
stephenhand merged 46 commits into
masterfrom
CHI-3295-formdef_package_move
May 23, 2025
Merged

Chi 3295 formdef package move#2962
stephenhand merged 46 commits into
masterfrom
CHI-3295-formdef_package_move

Conversation

@stephenhand

@stephenhand stephenhand commented May 12, 2025

Copy link
Copy Markdown
Collaborator

Review after #2958 merged

Description

Moves hrm-form-definitions under lambda/packages so it can be used in the lambdas workspace.
A few additional dependency and workflow updates were also required

Checklist

  • Corresponding issue has been opened
  • New tests added
  • [n/a] Feature flags added
  • [n/a] Strings are localized
  • Tested for chat contacts
  • Tested for call contacts

Other Related Issues

None

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@stephenhand stephenhand requested a review from mythilytm May 12, 2025 19:32
@gpaoloni gpaoloni changed the base branch from master to CHI-3295-update_prepopulate_logic May 16, 2025 20:10

@gpaoloni gpaoloni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is the workaround for #2960 not working, right?

…e_defs

CHI-3295: use new prepopulate config in Twilio Lambda
Base automatically changed from CHI-3295-update_prepopulate_logic to master May 22, 2025 11:57
# Conflicts:
#	lambdas/account-scoped/src/hrm/populateHrmContactFormFromTaskByKeys.ts
#	lambdas/packages/hrm-form-definitions/form-definitions/as/v1/PostSurvey.json
#	lambdas/packages/hrm-form-definitions/package.json
@stephenhand stephenhand merged commit 176f270 into master May 23, 2025
11 checks passed
@stephenhand stephenhand deleted the CHI-3295-formdef_package_move branch May 23, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants