sjh/remove_cypress#4494
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the Cypress end-to-end testing setup from aselo-webchat-react-app (dependencies and the cypress/ test tree), and also drops node-fetch usage from the scripts workspace.
Changes:
- Removed Cypress and
cypress-file-uploadfromaselo-webchat-react-appand deleted the associated Cypress test/support code. - Removed
node-fetchfromscriptsdependencies and removed its import fromsetAppConfigCreds.ts. - Updated both workspaces’ lockfiles to reflect the dependency removals.
Reviewed changes
Copilot reviewed 23 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/src/setAppConfigCreds.ts | Removes the node-fetch import from the script that generates appConfig.js credentials. |
| scripts/package.json | Removes node-fetch dependency from the scripts workspace. |
| scripts/package-lock.json | Updates lockfile to remove node-fetch and transitive dependencies. |
| aselo-webchat-react-app/package.json | Removes Cypress-related devDependencies. |
| aselo-webchat-react-app/package-lock.json | Updates lockfile to remove Cypress-related packages and transitive dependencies. |
| aselo-webchat-react-app/cypress/utils/constants.ts | Deletes Cypress test constants. |
| aselo-webchat-react-app/cypress/tsconfig.json | Deletes Cypress-specific TypeScript config. |
| aselo-webchat-react-app/cypress/support/e2e.ts | Deletes Cypress support entry. |
| aselo-webchat-react-app/cypress/support/commands/webchatSessionCookie.ts | Deletes custom Cypress session cookie helpers. |
| aselo-webchat-react-app/cypress/support/commands/index.ts | Deletes Cypress command registrations and chainable typings. |
| aselo-webchat-react-app/cypress/support/commands/createNewWebchat.ts | Deletes helper for creating a new webchat session in Cypress. |
| aselo-webchat-react-app/cypress/support/commands/addAttachmentFileAndSend.ts | Deletes Cypress helpers for attachment upload and message validation. |
| aselo-webchat-react-app/cypress/plugins/helpers/twilioClient.ts | Deletes Cypress plugin Twilio client helper. |
| aselo-webchat-react-app/cypress/plugins/helpers/interactionHandler.ts | Deletes Cypress plugin helpers for accepting/wrapping/completing interactions and fetching messages. |
| aselo-webchat-react-app/cypress/plugins/helpers/gmail-api-helper.ts | Deletes Gmail API helper used by Cypress plugins. |
| aselo-webchat-react-app/cypress/plugins/helpers/getWorker.ts | Deletes Cypress plugin helper for worker/task/reservation operations. |
| aselo-webchat-react-app/cypress/plugins/helpers/getToken.ts | Deletes Cypress plugin helper for generating worker JWTs. |
| aselo-webchat-react-app/cypress/pageObjects/preEngagementChatForm.ts | Deletes Cypress page object for pre-engagement form. |
| aselo-webchat-react-app/cypress/pageObjects/endChatView.ts | Deletes Cypress page object for end-chat view. |
| aselo-webchat-react-app/cypress/pageObjects/Chat/messageInputBoxView.ts | Deletes Cypress page object for message input/attachments. |
| aselo-webchat-react-app/cypress/pageObjects/Chat/chatNotificationView.ts | Deletes Cypress page object for alert/notification UI. |
| aselo-webchat-react-app/cypress/pageObjects/Chat/chatMessagesView.ts | Deletes Cypress page object for message list/separators. |
| aselo-webchat-react-app/cypress/fixtures/files/test.txt | Deletes Cypress fixture file. |
| aselo-webchat-react-app/cypress/fixtures/files/test.json | Deletes Cypress fixture file. |
| aselo-webchat-react-app/cypress/e2e/General/WebchatGeneral.cy.ts | Deletes the Cypress E2E spec suite. |
Files not reviewed (2)
- aselo-webchat-react-app/package-lock.json: Generated file
- scripts/package-lock.json: Generated file
Comment on lines
1
to
4
| import { config } from 'dotenv'; | ||
| import yargs from 'yargs'; | ||
| import fetch from 'node-fetch'; | ||
| import * as fs from 'node:fs/promises'; | ||
| import { getSSMParameter, setRoleToAssume } from './helpers/ssm'; |
Comment on lines
60
to
64
| "axios": "^1.18.0", | ||
| "cors": "^2.8.5", | ||
| "cross-env": "^10.1.0", | ||
| "cypress": "15.10.0", | ||
| "cypress-file-upload": "^5.0.8", | ||
| "dotenv": "^16.0.0", | ||
| "eslint": "^7.11.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P