Fix encoding bug#173
Open
tomsommer wants to merge 2 commits into
Open
Conversation
in_array() is case-sensitive and $parameters['charset'] is lower-case while mb_list_encodings() is upper-case
Contributor
Author
|
Fixes #148 |
|
👍 Although probably might be better to use |
|
thanks for bug resolution! it should be merged. |
This was referenced Apr 20, 2017
|
so has this fix been merged or not? |
dmromanov
suggested changes
Oct 10, 2017
|
Will this PR ever be merged & closed? |
nurtext
pushed a commit
to nurtext/Fetch
that referenced
this pull request
Sep 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in_array() is case-sensitive and $parameters['charset'] is lower-case while mb_list_encodings() is upper-case