ci: split ci into a matrix job - #447
Open
BjoernKarma wants to merge 3 commits into
Open
Conversation
… jobs for special cases (common, common_server, snapshotter) so the current default behavior stays intact
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the repository’s main CI workflow by replacing many per-module reusable-workflow jobs with a single matrix-driven job, while keeping a few special cases as dedicated jobs. It reduces repetition in .github/workflows/ci.yaml and introduces a single “CI Summary” job intended to be used for branch protection aggregation.
Changes:
- Replaced most per-module jobs with a
go_cimatrix job (fail-fast disabled, max 6 in parallel) that callsreusable-go-ci.yamlwith per-module parameters. - Kept dedicated jobs for
common,common_server, andsnapshotter, plus the tag-onlycommon_server_helmrelease job. - Added a
ci_summaryjob that summarizes results and fails the workflow if any required job fails (allowingcommon_server_helmto be skipped when not on tags).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI: Refactor per-module jobs into a matrix build
What changed
The
ci.yamlworkflow previously defined 22 separate top-level jobs — one per module — each callingreusable-go-ci.yamlindividually. This PR replaces that repetitive structure with:go_cimatrix job covering 19 modules (up to 6 running in parallel), with all per-module configuration encoded as matrix entries.common,common_server) for modules with non-standard flags (e.g.run_build_image: falsefor the library-onlycommonmodule).snapshotterjob because it requiresrun_lint: false, which cannot be expressed in the shared matrix.ci_summaryjob that aggregates all results and acts as a single aggregation point for branch protection rules.Why this makes sense
CI Summarycheck aggregates everythingfail-fast: false— all modules run, all failures visibleWhat is preserved
coverage_threshold,run_check_generated_files,lint_fail_on_issues,ko_build_path) are encoded in the matrix entries with the same values as before.reusable-go-ci.yamlis unchanged — each call still runstests → build image.common_server_helm) still depends oncommon_serverand only runs on tag pushes.main, tag, schedule, orworkflow_dispatchtriggers.Action required after merge
If branch protection rules reference specific job names from the old workflow (e.g.
"Approval / Tests & Coverage for approval"), update them to referenceCI Summaryas the single required status check.