feat(cpapi): Added owner Application on Api and EvenType entities - #619
Open
iagarba wants to merge 3 commits into
Open
feat(cpapi): Added owner Application on Api and EvenType entities#619iagarba wants to merge 3 commits into
iagarba wants to merge 3 commits into
Conversation
iagarba
requested review from
BjoernKarma,
julius-malcovsky,
ron96g and
stefan-ctrl
and
a lite review from Copilot
August 21, 2026 07:02
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Controlplane GraphQL API (controlplane-api) to expose a cross-tenant-safe “owner application” reference for catalogue entities (Api, EventType), intended for UI link resolution.
Changes:
- Added a new GraphQL type
OwnerApplicationInfoand exposed it viaApi.ownerApplicationandEventType.ownerApplication. - Implemented resolvers that traverse from the active exposure to the owning application using
SystemContext, returning onlyapplicationIdand optionalictoNumber. - Added Ginkgo/Gomega tests covering resolver behavior and ICTO external-id extraction.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| controlplane-api/schema.graphql | Adds OwnerApplicationInfo type and new ownerApplication fields on Api and EventType. |
| controlplane-api/pkg/model/owner_application_info.go | Introduces the reduced Go model returned by the new GraphQL field. |
| controlplane-api/internal/resolvers/schema.resolvers.go | Implements OwnerApplication resolvers for Api and EventType. |
| controlplane-api/internal/resolvers/mapper.go | Adds mapping + ICTO number extraction helper for reduced owner application view. |
| controlplane-api/internal/resolvers/schema_resolvers_catalogue_owner_test.go | Adds resolver tests for ownerApplication on Api and EventType. |
| controlplane-api/gqlgen.yml | Registers OwnerApplicationInfo model mapping for gqlgen. |
| controlplane-api/internal/resolvers/schema.generated.go | Generated gqlgen output for OwnerApplicationInfo and field wiring. |
| controlplane-api/internal/resolvers/root_.generated.go | Generated complexity and schema wiring for new fields/type. |
| controlplane-api/internal/resolvers/ent.generated.go | Generated resolver interfaces and execution wiring for new fields/type. |
Files not reviewed (3)
- controlplane-api/internal/resolvers/root_.generated.go: Generated file
- controlplane-api/internal/resolvers/schema.generated.go: Generated file
- controlplane-api/internal/resolvers/schema.resolvers.go: Generated file
Suppressed comments (1)
controlplane-api/internal/resolvers/schema.resolvers.go:532
- Use Only(sysCtx) instead of First(sysCtx) when querying the active exposure, to be consistent with ActiveExposure and to avoid returning a non-deterministic ownerApplication if multiple exposures are incorrectly marked active.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…he active exposure
stefan-ctrl
requested changes
Aug 24, 2026
…ctoNumber as a hard-coded entity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.