Inline Nexus workflow ID formatting#762
Open
Sushisource wants to merge 3 commits intomainfrom
Open
Conversation
Sushisource
requested review from
a team,
antmendoza and
tsurdilo
as code owners
VegetarianOrc
force-pushed
the
codex/update-workflow-ids-in-nexus-samples
branch
from
b235450 to
4cc3fe0
Compare
chrsmith
approved these changes
Apr 28, 2026
chrsmith
left a comment
chrsmith
left a comment
There was a problem hiding this comment.
Minor nit, feel free to submit as-is.
Comment on lines
+59
to
+60
| // dedupe workflow starts. | ||
| // For this example, tie the workflow ID to the customer being greeted so |
There was a problem hiding this comment.
Minor nit: The new comment doesn't have a line break between paragraphs, but does have one on line 62. So just adding a \n here to be consistent.
Suggested change
| // dedupe workflow starts. | |
| // For this example, tie the workflow ID to the customer being greeted so | |
| // dedupe workflow starts. | |
| // | |
| // For this example, tie the workflow ID to the customer being greeted so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use proper business IDs instead of request IDs in nexus samples, per temporalio/features#692
Codex Task