Add escargot - #125
Open
M-SE0K wants to merge 3 commits into
Open
Conversation
Signed-off-by: M-SE0K <seg082911@gmail.com>
Signed-off-by: M-SE0K <seg082911@gmail.com>
Signed-off-by: M-SE0K <seg082911@gmail.com>
Contributor
|
Cc: #124 (review) |
M-SE0K
marked this pull request as draft
August 12, 2026 06:17
M-SE0K
marked this pull request as ready for review
August 12, 2026 06:21
Author
|
@CanadaHonk Could you please review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two build note:
escargot links against icu, which is keg-only in homebrew and so invisible to pkg-config, hence the
PKG_CONFIG_PATHhandling on darwin. And escargot and its submodules still declarecmake_minimum_required(VERSION 2.8.12), which cmake 4 rejects outright since it dropped compatibility with policy versions below 3.5 —-DCMAKE_POLICY_VERSION_MINIMUM=3.5works around this until escargot bumps its minimum.Built and ran a full test262 pass on both Linux (x64) and macOS (arm64).