fix: add info params + fix WO auth#88
Merged
Merged
Conversation
…schema Accept optional info object with notes, remarks, site, and location on POST /auth/work-orders and PATCH /auth/work-orders/:id. The handler merges these into the thing info alongside the top-level fields.
tokenHasPerms received bare resource names (e.g. 'work_order') from route perms, but _permsMatch expects 'resource:level' format. Splitting a bare name by ':' left `required` as undefined, crashing on spread.
mukama
changed the title
mukama
changed the title
mukama
changed the title
paragmore
approved these changes
Jun 4, 2026
boris91
approved these changes
Jun 4, 2026
tekwani
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
infosub-object to work order create and update schemas, acceptingnotes,remarks,site, andlocationfieldsinfofields flat into the thing info (no nestedinfo.info)tokenHasPermscrashed with"required is not iterable"when route perms passed bare resource names (e.g.'work_order')._permsMatchexpectsresource:levelformat — splitting a bare name by:leftrequiredasundefined. Fix auto-qualifies bare perms with the appropriate level (rw/r) based on the write flag.Impact
permsparameter (work-orders and spare-parts) on stagingnotes,remarks,site, andlocationon work order create/update