fix(AppShell): correct Inventory take/drop editor and Attributes editor gaps - #1960
Merged
Merged
Conversation
…or gaps The WASM editor bridge's multi-attribute dropdown type resolution never recognized boolean values, so the Inventory tab's "Take"/"Drop" dropdown appeared blank instead of defaulting to "Default behaviour", and its "Object can be taken"/"Take message" controls never rendered. Switching the dropdown back from "Run script" to "Default behaviour" also silently failed since SetMultiType had no boolean case. Also fixes the Attributes editor to match the v5 desktop editor: elementtype/type are now fully locked (never editable), name's type is locked to string (but its value can still be edited to rename), and adds an "Add Change Script" button (creates a changed<attr> script attribute) that's available for inherited attributes as v5 allows, with a "Go to Change Script" button shown instead when one already exists. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
alexwarren
enabled auto-merge (squash)
July 29, 2026 21:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several gaps in the AppShell editor found while comparing it against the v5 desktop/web editors:
Inventory tab (Take/Drop):
AddDropdownTypeValues(WASM bridge) never resolvedboolvalues to"boolean", so the Take/Drop dropdown showed blank instead of defaulting to "Default behaviour", and the "Object can be taken"/"Take message" controls never rendered (no boolean branch existed inPropertyEditor.svelte's "multi" control renderer).SetMultiTypehad no"boolean"case, so switching the dropdown back from "Run script" to "Default behaviour" silently failed (hit the unknown-type fallback).<checkbox>caption through a newcheckboxCaptionfield onControlInfoso the checkbox label ("Object can be taken") renders correctly.Attributes editor:
elementtype/typeare now fully locked (type dropdown + value), since they identify the element and must never be hand-edited.name's type dropdown is locked to string, but its value stays editable (renaming still works).changed<attr>script attribute), matching v5'sWFAttributesControl.AddChangeScriptAllowed— including for inherited attributes, which v5 also allows (unlike delete, which v5 blocks for inherited attributes).changed<attr>already exists, shows a "Go to Change Script" button instead, which selects and scrolls to that attribute.Test plan
dotnet build src/WasmEditor/WasmEditor.csproj— 0 errors/warningsnpm run check(svelte-check) insrc/AppShell— 0 errors/warningsplayerobject):elementtype/typerows: type dropdown and value both disablednamerow: type dropdown disabled, value still editabletakecreateschangedtakeand selects it; hidden forelementtype/type/nameisopen(haschangedisopen) and correctly navigates to it🤖 Generated with Claude Code