Add a check for superfluous capture groups - #55
Merged
Conversation
This was suggested in pygments/pygments#3232 (comment) by @birkenfeld
thatch
added a commit
that referenced
this pull request
Jul 31, 2026
Renumber check_redundant_noncapturing_group from 129 to 133; it collided with checks added by #55-#58 (129-132), since all were written independently against the same base. Also fix test_run_all_checkers_no_errors: it used (?:x) as a baseline 'no errors expected' pattern, but that group is now correctly flagged as redundant by the new check. Switched to a plain 'x' with no group to keep the test's intent.
thatch
added a commit
that referenced
this pull request
Jul 31, 2026
This is the second time independent PRs collided on the same message id (126 across #52/#53/#54, now 129 across #55-#59). Statically walk each check_/bygroups_check_/groups_check_ function's source for its 'num' assignment and assert none repeat, so a future collision fails CI instead of silently shipping ambiguous warning codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was suggested in pygments/pygments#3232 (comment) by @birkenfeld