chore: remove unused starter scaffolding - #16
Open
PouyanJay wants to merge 1 commit into
Open
Conversation
Scaffolding from the vinext template that nothing references. Database: drizzle is not imported anywhere in app/, and .openai/hosting.json sets "d1": null so no binding is ever created. Removes drizzle-kit and drizzle-orm, db/, examples/d1/, drizzle/, drizzle.config.ts and the db:generate script. drizzle-kit pulled the @esbuild-kit chain, so this clears 3 of the 18 npm advisories and takes moderate-severity findings to zero. Assets: public/basis/ is 576 KB of KTX2 transcoder that is never registered — loaders.ts sets the meshopt decoder and nothing else. public/draco/ is deliberately kept: also unloaded today, but it is what segmented-asset work needs. Modules: tsl-materials.ts exports a node nothing imports, and chatgpt-auth.ts is the starter's sign-in helper, never called. README described D1 bindings and ChatGPT sign-in and never mentioned Anatomy Atelier. Rewritten around what the project actually is, with the two things worth knowing before touching the viewer: it renders on demand, and organs are normalised into a fixed cube so hotspot coordinates mean the same thing for every model. The drizzle copy step in build/sites-vite-plugin.ts is left alone — it is guarded by an existence check, so it is harmless with the directory gone, and it is generic build infrastructure rather than app code. Fixes thebuggeddev#13
|
@PouyanJay is attempting to deploy a commit to the thebuggeddev-9222's projects Team on Vercel. A member of the Team first needs to authorize it. |
PouyanJay
force-pushed
the
fix/13-dead-code
branch
from
August 7, 2026 07:46
8aeb99b to
322c0db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13.
Scaffolding inherited from the vinext template that nothing references. Ten files deleted, 210 lines removed, ~600 KB off the shipped assets, and three npm advisories gone.
Database — never wired up
drizzleisn't imported anywhere inapp/, and.openai/hosting.jsonsets"d1": null, so no binding is ever created.Removed
drizzle-kit,drizzle-orm,db/,examples/d1/,drizzle/,drizzle.config.ts, and thedb:generatescript.drizzle-kitwas pulling the vulnerable@esbuild-kit/*chain, so this takes moderate-severity advisories to zero.Assets
public/basis/— 576 KB of KTX2 transcoder that is never registered. loaders.ts sets the meshopt decoder and nothing else.public/draco/— also unloaded today, but it's exactly what segmented-asset work needs, and registeringDRACOLoaderis on the roadmap. Deleting it now would only mean re-adding it later.Dead modules
app/lib/three/tsl-materials.ts— exportsmedicalRimNode, which nothing importsapp/chatgpt-auth.ts— the starter's SIWC helper, never calledREADME
Was still the untouched starter readme: it documented D1 bindings and ChatGPT sign-in, and never mentioned Anatomy Atelier. Rewritten around what the project actually is, including the two things worth knowing before touching the viewer — it renders on demand, and organs are normalised into a fixed cube so hotspot coordinates mean the same thing for every model.
Deliberately left alone
AnatomyViewer.prefetch()and theAnatomyAssetManager.prefetch()it delegates to are genuinely unreachable —AnatomyAppdoes its own warm-up on pointer enter. But removing three lines fromviewer.tswould collide with fix: unblock the underside, make the cross-section real and movable, replace the selection heart (#8) #9's 371-line rewrite of that same file for no benefit. Worth doing as a follow-up once fix: unblock the underside, make the cross-section real and movable, replace the selection heart (#8) #9 lands.build/sites-vite-plugin.ts— guarded by an existence check, so harmless with the directory gone, and it's generic build infrastructure rather than app code.Verification
tsc --noEmitclean,eslint app workercleannpm auditon this branch alone: 18 → 15, moderate 4 → 0npm testfails on this branch in isolation becausemainstill carries the broken starter test. #14 fixes that. The 6/6 above comes from a scratch branch with all three merged.Touches
package.jsonand the lockfile, as does #15 — whichever merges second will need a rebase and annpm install.