feat(i18n): add Vietnamese locale - #17
Open
thaohienhomes wants to merge 1 commit into
Open
Conversation
Adds `vi` as a thirteenth locale: 231 UI strings, all nine organs, and all thirty-six hotspots. Vietnamese gets its own `ScriptGroup` rather than reusing `latin`, because DM Sans ships no Vietnamese subset — the tone marks fall back to a system face mid-paragraph. The sans face becomes Be Vietnam Pro, drawn for these diacritics so the marks clear the ascenders; Cormorant Garamond stays, with its `vietnamese` subset requested. Only `vi` loads that pair, so the twelve existing locales pay nothing. Terminology follows Vietnamese medical usage (tâm nhĩ / tâm thất, van hai lá, tá tràng, hỗng tràng, biểu bì / trung bì / hạ bì). Numbers follow Vietnamese convention — comma for decimals, period for thousands: `1,3–1,4 kg`, `100.000 lần`. `npm run i18n:audit` passes with no errors.
|
@claude is attempting to deploy a commit to the thebuggeddev-9222's projects Team on Vercel. A member of the Team first needs to authorize it. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
vias a thirteenth locale — 231 UI strings, all nine organs, allthirty-six hotspots.
npm run i18n:auditpasses with no errors.One design decision worth flagging: Vietnamese gets its own
ScriptGrouprather than reusing
latin. DM Sans ships no Vietnamese subset, so the tonemarks fall back to a system face mid-paragraph and the text visibly breaks
apart. The sans face for
vibecomes Be Vietnam Pro, which is drawn for thesediacritics so the marks clear the ascenders; Cormorant Garamond stays as the
serif, with its
vietnamesesubset requested. Onlyviloads that pair — thetwelve existing locales are untouched and download nothing extra.
Terminology follows Vietnamese medical usage (tâm nhĩ / tâm thất, van hai lá,
tá tràng, hỗng tràng, biểu bì / trung bì / hạ bì) rather than literal
translation. Numbers follow Vietnamese convention: comma for decimals, period
for thousands —
1,3–1,4 kg,100.000 lần.Related to #3, which asked for multilingual support before the i18n layer
landed — that request is now covered by
app/i18n/, and this adds one morelanguage to it. You may want to close that issue.
Happy to adjust anything, or to drop the font change and let
viride onlatinif you would rather keep the font list short — the tone marks willdegrade, but the PR would shrink to three files.