Remove an obsolete module and update user privileges - #4928
Merged
aneta-petrova merged 2 commits intoJul 1, 2026
Conversation
github-actions
Bot
added
Needs tech review
10 tasks
Member
Author
|
Hi @qcjames53, can you please review? This PR proposes to remove the module you reviewed in https://github.com/theforeman/foreman-documentation/pull/4843/changes#r3356365012. |
aneta-petrova
changed the title
aneta-petrova
force-pushed
the
fix-permission-issues
branch
from
June 11, 2026 17:20
cd0704d to
d0a4199
Compare
Contributor
|
@aneta-petrova Please rebase to HEAD of "master". |
jafiala
added
style review done
aneta-petrova
force-pushed
the
fix-permission-issues
branch
from
July 1, 2026 06:12
d0a4199 to
a98a3e7
Compare
aneta-petrova
force-pushed
the
fix-permission-issues
branch
from
July 1, 2026 06:14
a98a3e7 to
d996cd2
Compare
Member
Author
|
Tech ack for the user privileges part was given in #4843 (comment) Tech ack for the part that removes a module was given in #4843 (comment) Based on these comments, I'm adding the |
aneta-petrova
added
tech review done
aneta-petrova
added a commit
that referenced
this pull request
Jul 1, 2026
* Remove an obsolete module * foreman-maintain health can be run as a regular user (cherry picked from commit d07240b) (cherry picked from commit 98160fc8d426f195f3955b5ac82dde766b920929) (cherry picked from commit 1bdf670d2f06a70c72caba1b8f847ac73b0e0239)
aneta-petrova
added a commit
that referenced
this pull request
Jul 1, 2026
* Remove an obsolete module * foreman-maintain health can be run as a regular user (cherry picked from commit d07240b) (cherry picked from commit 98160fc8d426f195f3955b5ac82dde766b920929)
aneta-petrova
added a commit
that referenced
this pull request
Jul 1, 2026
* Remove an obsolete module * foreman-maintain health can be run as a regular user (cherry picked from commit d07240b)
aneta-petrova
added a commit
that referenced
this pull request
Jul 1, 2026
* Remove an obsolete module * foreman-maintain health can be run as a regular user (cherry picked from commit d07240b)
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://github.com/theforeman/foreman-documentation/pull/4843/changes#r3356365012
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
N/A
Contributor checklists
Please cherry-pick my commits into: