Remove the references to the katello-ca/rhsm-consumer RPM - #5226
Open
jsvarova wants to merge 7 commits into
Open
Remove the references to the katello-ca/rhsm-consumer RPM #5226jsvarova wants to merge 7 commits into
jsvarova wants to merge 7 commits into
Conversation
github-actions
Bot
added
Needs tech review
jsvarova
marked this pull request as draft
August 20, 2026 09:04
jsvarova
changed the title
Contributor
Author
|
I've unticked two cherry-picked branches. This PR applies to Foreman 5.0 only. |
jsvarova
marked this pull request as ready for review
August 27, 2026 15:18
Contributor
Author
|
Thank you @maximiliankolb , I just applied your suggestions. |
maximiliankolb
left a comment
maximiliankolb
left a comment
Contributor
There was a problem hiding this comment.
The removal of /pub/ mostly LGTM; I left one question. A technical ACK would be nice.
| endif::[] | ||
|
|
||
| ifndef::containerized[] | ||
| include::modules/con_using-custom-ssl-certificate-for-hosts.adoc[leveloffset=+1] |
Contributor
There was a problem hiding this comment.
I am a bit unsure about the title and placement of this module. Should it be renamed to "Reverting to default self-signed certificates" or similar?
It's kinda short, and then title+abstract does not match line 10.
Contributor
Author
There was a problem hiding this comment.
I decided to remove the whole module. It contains leftovers of the original ch8, but no longer holds any important content. Pending technical review.
Contributor
|
Please, rebase on |
The Procedure template requires Next steps to be a bulleted list of links without additional explanatory text. This change converts the paragraph-style Next steps section to the required format. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…to-smart-proxy-server.adoc Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
…-default-self-signed-certificate-on-smart-proxy-server.adoc Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
jsvarova
force-pushed
the
SAT-48862-remove-references-to-katello-ca-consumer
branch
from
August 31, 2026 13:04
87ab61a to
9a5efa4
Compare
pr-processor
Bot
added
Needs re-review
and removed
Waiting on contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Removing references to the katello-ca-consumer RPM package.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
the katello-ca-consumer RPM package has been removed from the project and references to it thus cannot stay in the docs.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
https://redhat.atlassian.net/browse/SAT-48862
Contributor checklists
Please cherry-pick my commits into: