Hide Complete Mirroring mirroring policy for SLES - #5254
Open
maximiliankolb wants to merge 1 commit into
Open
Conversation
The SCC Manager plugin does not allow users to configure mirroring policy "Complete Mirroring" for new SUSE content. However, users can theoretically change the mirroring policy after setting up SUSE content via SCC Manager plugin. This patch hides this section for SUSE Linux Enterprise Server Clients. This patch also hides Yum repositories for Deb Clients. Downstream docs for Debian or Ubuntu Client OS do not show the mirroring policy for Yum content. Only RHEL Clients show the mirroring policy for Red Hat content. This patch does not affect upstream builds. Fixes theforeman#4333 (SUSE content: Avoid mirroring policy "Complete Mirroring")
github-actions
Bot
added
Needs tech review
Contributor
Author
|
I created this upstream PR based on ATIX-AG/foreman_scc_manager#161 (comment). Does it match your expectation? @nadjaheitmann I checked that the SCC Manager plugin does not show "complete mirroring" & that users could, if they wanted to, still change the mirroring policy for Yum content from SUSE. IMO that makes it a good idea to hide it for SLES clients so users don't set it to "complete mirroring". |
|
The PR preview for e05a243 is available at theforeman-foreman-documentation-preview-pr-5254.surge.sh The following output files are affected by this PR: |
|
Looks good to me, thanks @maximiliankolb . I think it is a bit sneaky to add the Deb change in the same commit but fine for me if it's okay for you ;) |
maximiliankolb
added
tech review done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
The SCC Manager plugin does not allow users to configure mirroring policy "Complete Mirroring" for new SUSE content. However, users can theoretically change the mirroring policy after setting up SUSE content via SCC Manager plugin.
This patch hides this section for SUSE Linux Enterprise Server Clients.
This patch also hides Yum repositories for Deb Clients. Downstream docs for Debian or Ubuntu Client OS do not show the mirroring policy for Yum content. Only RHEL Clients show the mirroring policy for Red Hat content.
This patch does not affect upstream builds.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Fixes #4333 (SUSE content: Avoid mirroring policy "Complete Mirroring")
Contributor checklists
Please cherry-pick my commits into: