Reuse obsah_params fixture to read parameters

[ekohl]

Why are you introducing these changes? (Problem description, related links)

While working on #511 I wanted to move the file to a new location. It broke due to deriving the parameters location from the test filename.

What are the changes introduced in this pull request?

• Reuse obsah_params fixture that's already defined to avoid duplicating logic

How to test this pull request

Steps to reproduce:

• Run the test suite
• Verify it passes

Checklist

• Tests added/updated (if applicable)
• Documentation updated (if applicable)

[arvind4501]

I think then

foremanctl/tests/migration_test.py

Lines 7 to 9 in 9ffe360

	@pytest.fixture(scope="module")
	def obsah_state_path():
	return os.environ.get("OBSAH_STATE", "/var/lib/foremanctl")

should also be using shared fixture

[ekohl]

I looked at that, but the test asserts that the file exists. There's a subtle on paths difference. Compare:

foremanctl/tests/conftest.py

Line 19 in 9ffe360

OBSAH_STATE = os.environ.get('OBSAH_STATE', '.var/lib/foremanctl')

foremanctl/tests/migration_test.py

Line 9 in 9ffe360

return os.environ.get("OBSAH_STATE", "/var/lib/foremanctl")

I didn't want to untangle that too and for now only focus on reducing the size of #511.

[arvind4501]

Sorry i did not catch that .var/* and /var* earlier, and that make sense, thank you :)

[ekohl]

I must admit I didn't either until you asked me to look at it again. Only then I spotted it.