Fixes #449 - Add container-gateway to capsule flavor features - #792
Merged
Merged
Conversation
Add container-gateway to capsule.yml's flavor_features, matching foreman-proxy-content.yml. Covered by the existing tests/feature/container-gateway suite.
ehelms
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Adds
container-gatewayto thecapsuleflavor'sflavor_features, matchingthe
foreman-proxy-contentflavor which has carried it since #611.Why are you introducing these changes?
Issue #449 originally scoped the container-gateway feature for "foreman proxy
content, or capsules in the Satellite ecosystem" -- but #611 only added it to
foreman-proxy-content.yml, and thecapsuleflavor (introduced later in#735) never got it either. As a result, capsules deployed with
--flavor capsulerespond with a raw 404 to registry pulls (/v2/) routedthrough them, directly or via a load-balanced capsule proxy, since nothing on
the capsule's httpd config recognizes that path.
How to test this pull request
--flavor capsule.container-gatewayshows asenabledinforemanctl features.podman login <capsule-fqdn> --tls-verify=falseshould succeed (this isexercised by the existing
tests/feature/container-gatewaysuite, whichis feature-based and will now also run against the
capsuleflavor).Verified live end-to-end on a real capsule (foremanctl RPM install): before
the fix,
container-gatewayshowed asavailable(not enabled) and/v2/returned a raw HTML 404; after redeploying with the patched flavor file,
container-gatewayshowsenabled,/v2/returns a proper401challenge,and
podman loginsucceeds.Fixes #449
🤖 Generated with Claude Code