Refs #39354 - Update RuboCop dependencies - #957
Merged
Conversation
Update RuboCop and its performance extension to releases that allow unicode-display_width 3.x in the generated CI lockfile. Assisted-By: Codex 5.6 Sol High <noreply@openai.com>
ehelms
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This removes RuboCop's
< 3.0restriction onunicode-display_width, allowing the generated Smart Proxy CI lockfile to align on the 3.x release used by the other Foreman projects.Thor remains blocked
The
thorpart of #39354 cannot be resolved bybundle update: Facter 4.11.0 still declaresthor >= 1.0.1, < 1.3to retain Ruby 2.5 support. The upstream change to remove that restriction is still open in puppetlabs/facter#2751. Raising Thor in Smart Proxy before a compatible Facter release would make the bundle unsatisfiable, so this PR deliberately usesRefsrather than claiming to fix the whole issue.Validation
unicode-display_width >= 2.4, < 4.0The generated lockfile and RuboCop run will be validated by the upstream CI matrix.
AI assistance disclosure: This pull request was prepared with assistance from Codex 5.6 Sol High. The changes were reviewed by the author.