Skip to content

Refs #39641 - Support remote_execution_remote_working_dir in push mode - #134

Merged
adamlazik1 merged 1 commit into
theforeman:masterfrom
michalgritzbach:39641-remote-working-dir-push
Aug 26, 2026
Merged

Refs #39641 - Support remote_execution_remote_working_dir in push mode#134
adamlazik1 merged 1 commit into
theforeman:masterfrom
michalgritzbach:39641-remote-working-dir-push

Conversation

@michalgritzbach

Copy link
Copy Markdown

Ensures that remote working dir path begins with /.

@adamruzicka adamruzicka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright

Comment thread lib/smart_proxy_remote_execution_ssh/runners/script_runner.rb Outdated
@adamruzicka adamruzicka changed the title Refs #39641 - Ensure remote_working_dir is absolute Refs #39641 - Support remote_execution_remote_working_dir in push mode Aug 19, 2026
@adamruzicka

Copy link
Copy Markdown
Contributor

Note: companion to theforeman/foreman_remote_execution#1057

@adamlazik1 adamlazik1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works. One nitpick.

Comment thread lib/smart_proxy_remote_execution_ssh/runners/script_runner.rb Outdated
@adamlazik1

Copy link
Copy Markdown
Contributor

Also nitpick, but please change Refs to Fixes.

Comment thread lib/smart_proxy_remote_execution_ssh/runners/script_runner.rb Outdated
@michalgritzbach
michalgritzbach force-pushed the 39641-remote-working-dir-push branch from e409aa7 to c320975 Compare August 25, 2026 11:39
@michalgritzbach
michalgritzbach force-pushed the 39641-remote-working-dir-push branch from c320975 to add6f79 Compare August 25, 2026 14:23

@adamlazik1 adamlazik1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamlazik1
adamlazik1 merged commit e281503 into theforeman:master Aug 26, 2026
11 checks passed
@adamlazik1

Copy link
Copy Markdown
Contributor

Thanks @michalgritzbach !

@michalgritzbach
michalgritzbach deleted the 39641-remote-working-dir-push branch August 26, 2026 11:26
@lpramuk

lpramuk commented Aug 26, 2026

Copy link
Copy Markdown

Cherrypick ? We've branched

-edit: Oh, it's a plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants