Refs #39641 - Support remote_execution_remote_working_dir in push mode - #134
Merged
adamlazik1 merged 1 commit intoAug 26, 2026
Merged
Conversation
adamruzicka
reviewed
Aug 19, 2026
Contributor
|
Note: companion to theforeman/foreman_remote_execution#1057 |
adamlazik1
reviewed
Aug 24, 2026
adamlazik1
left a comment
Contributor
There was a problem hiding this comment.
LGTM and works. One nitpick.
Contributor
|
Also nitpick, but please change |
michalgritzbach
force-pushed
the
39641-remote-working-dir-push
branch
from
August 25, 2026 10:58
7b9ce1f to
e409aa7
Compare
adamlazik1
reviewed
Aug 25, 2026
michalgritzbach
force-pushed
the
39641-remote-working-dir-push
branch
from
August 25, 2026 11:39
e409aa7 to
c320975
Compare
michalgritzbach
force-pushed
the
39641-remote-working-dir-push
branch
from
August 25, 2026 14:23
c320975 to
add6f79
Compare
Contributor
|
Thanks @michalgritzbach ! |
|
Cherrypick ? We've branched -edit: Oh, it's a plugin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that remote working dir path begins with /.