Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 28 additions & 81 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"@eslint/js": "^9.32.0",
"@storybook/addon-a11y": "^9.0.18",
"@storybook/addon-coverage": "^2.0.0",
"@storybook/addon-designs": "^10.0.2",
"@storybook/addon-designs": "^11.1.4",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Design-viewer add-on upgraded to a version that only works with a newer Storybook than the project uses

The design-viewer add-on is upgraded to a version (@storybook/addon-designs ^11.1.4 at package.json:48) that only supports the next major Storybook release, while every other Storybook package in the project stays on the previous major, so installing and building the component gallery breaks.
Impact: Developers can no longer reliably install dependencies or start/build the Storybook component gallery, since the tool demands a Storybook version the project does not have.

Peer dependency mismatch between addon-designs 11 and Storybook 9

package-lock.json:2956-2960 shows @storybook/addon-designs@11.1.4 declares peer dependencies of storybook: ^10.0.0 (and @storybook/addon-docs: ^10.0.0). However the project pins the whole Storybook toolchain to 9.x: storybook resolves to 9.0.18 (package-lock.json:15531-15533) and package.json:49-88 keeps @storybook/addon-docs, @storybook/react-vite, storybook, etc. at ^9.0.18. The add-on is actively loaded via .storybook/main.ts:7, so this is not an unused dependency. With npm 7+ (repo requires npm >=10, package.json:102) this produces an ERESOLVE install failure, and even when force-installed the add-on built for Storybook 10 can misbehave at runtime in a Storybook 9 host. The bump should be held until the rest of the Storybook packages are upgraded to v10.

Prompt for agents
The bump of @storybook/addon-designs to ^11.1.4 introduces a peer dependency conflict: addon-designs@11 requires storybook and @storybook/addon-docs at ^10.0.0, but this project is entirely on the Storybook 9 toolchain (storybook, @storybook/react-vite, @storybook/addon-docs, etc. all pinned to ^9.0.18 in package.json, and storybook resolves to 9.0.18 in package-lock.json). The addon is registered in .storybook/main.ts, so it is loaded at build/dev time. Either revert this bump to the 10.x line that supports Storybook 9, or upgrade the entire Storybook toolchain to v10 in the same change so the peer ranges are satisfied.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"@storybook/addon-docs": "^9.0.18",
"@storybook/addon-links": "^9.0.18",
"@storybook/addon-themes": "^9.0.18",
Expand Down
Loading