-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps-dev): bump @storybook/addon-designs from 10.0.2 to 11.1.4 #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/npm_and_yarn/storybook/addon-designs-11.1.4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Design-viewer add-on upgraded to a version that only works with a newer Storybook than the project uses
The design-viewer add-on is upgraded to a version (
@storybook/addon-designs^11.1.4atpackage.json:48) that only supports the next major Storybook release, while every other Storybook package in the project stays on the previous major, so installing and building the component gallery breaks.Impact: Developers can no longer reliably install dependencies or start/build the Storybook component gallery, since the tool demands a Storybook version the project does not have.
Peer dependency mismatch between addon-designs 11 and Storybook 9
package-lock.json:2956-2960shows@storybook/addon-designs@11.1.4declares peer dependencies ofstorybook: ^10.0.0(and@storybook/addon-docs: ^10.0.0). However the project pins the whole Storybook toolchain to 9.x:storybookresolves to9.0.18(package-lock.json:15531-15533) andpackage.json:49-88keeps@storybook/addon-docs,@storybook/react-vite,storybook, etc. at^9.0.18. The add-on is actively loaded via.storybook/main.ts:7, so this is not an unused dependency. With npm 7+ (repo requires npm >=10,package.json:102) this produces an ERESOLVE install failure, and even when force-installed the add-on built for Storybook 10 can misbehave at runtime in a Storybook 9 host. The bump should be held until the rest of the Storybook packages are upgraded to v10.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.