Skip to content

fix: correct height and error styles for map with showOSSearch enabled#627

Open
jessicamcinchak wants to merge 2 commits into
mainfrom
jess/fix-error-height-styling
Open

fix: correct height and error styles for map with showOSSearch enabled#627
jessicamcinchak wants to merge 2 commits into
mainfrom
jess/fix-error-height-styling

Conversation

@jessicamcinchak

@jessicamcinchak jessicamcinchak commented May 14, 2026

Copy link
Copy Markdown
Member

Fixes two noticable issues when using in planx:

  • Autocomplete search error message
    • Missing govuk-style left border when visible
    • Not clearing on address selection change
  • Overall height when search + map are grouped
    • map class requires height to render (currently 100% with + without search); this means search + map are > 100% and overlapping other content like planx's MapFooter
    • To test / recreate: pnpm dev from this branch, see index.html elements overlapping here when map has search visible
image

@netlify

netlify Bot commented May 14, 2026

Copy link
Copy Markdown

Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit fa09311
🔍 Latest deploy log https://app.netlify.com/projects/oslmap/deploys/6a3a541650bfd3000923289d
😎 Deploy Preview https://deploy-preview-627--oslmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@DafyddLlyr

Copy link
Copy Markdown
Contributor

@jessicamcinchak I believe that fa09311 resolves the issue here..!

image

@DafyddLlyr DafyddLlyr marked this pull request as ready for review June 23, 2026 09:40

@joecarver joecarver left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both sets of fixes seem to be working for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants