fix: skip H2 for tunnel_request (single ops) — completes #1040#1041
Merged
therealaleph merged 1 commit intoMay 11, 2026
Merged
Conversation
…#1040 PR therealaleph#1040 skipped H2 for `tunnel_batch_request_to` but missed `tunnel_request` (used for plain `connect` ops). This caused 16-17s long-poll stalls to persist on full-tunnel sessions that go through the single-op path. Same fix: remove the H2 try/fallback/NonRetryable block, go straight to H1 pool acquire(). H2 remains active for relay mode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7 tasks
therealaleph
added a commit
that referenced
this pull request
May 11, 2026
…ops (#1041) Bumps Cargo.toml v1.9.21 → v1.9.22. Ships @yyoyoian-pixel's PR #1041 which completes #1040 — v1.9.21 skipped H2 for tunnel_batch_request_to but missed tunnel_request (single-op connect path). 5/5 h2_relay_request call sites now audited; all full-tunnel paths use H1, relay paths keep H2. 209 lib tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #1040 skipped H2 for
tunnel_batch_request_tobut missedtunnel_request(used for plainconnectops). This caused 16–17s long-poll stalls to persist on full-tunnel sessions that go through the single-op path.Same fix: remove the H2 try/fallback/NonRetryable block, go straight to H1 pool
acquire(). H2 remains active for relay mode.Verified
All
h2_relay_requestcall sites checked:do_relay_once_withrelay()exit-nodetunnel_requesttunnel_batch_request_totunnel_batch_request_with_timeoutNo other full-tunnel paths use H2 after this fix.
🤖 Generated with Claude Code