Skip to content

ASIO: provide bufferSwitchTimeInfo instead of leaving it NULL #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garyscavone merged 1 commit into from
Aug 18, 2026
Merged

ASIO: provide bufferSwitchTimeInfo instead of leaving it NULL #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion RtAudio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3365,6 +3365,8 @@ struct AsioHandle {
static const char* getAsioErrorString( ASIOError result );
static void sampleRateChanged( ASIOSampleRate sRate );
static long asioMessages( long selector, long value, void* message, double* opt );
static void bufferSwitch( long index, ASIOBool processNow );
static ASIOTime *bufferSwitchTimeInfo( ASIOTime *timeInfo, long index, ASIOBool processNow );

RtApiAsio :: RtApiAsio()
{
Expand Down Expand Up @@ -3548,6 +3550,16 @@ static void bufferSwitch( long index, ASIOBool /*processNow*/ )
object->callbackEvent( index );
}

// Some drivers call bufferSwitchTimeInfo() regardless of what the host answers to
// kAsioSupportsTimeInfo, so this callback must not be left NULL: those drivers would
// call through a null pointer and take the process down. We make no use of the time
// info, so hand the work to bufferSwitch().
static ASIOTime *bufferSwitchTimeInfo( ASIOTime * /*timeInfo*/, long index, ASIOBool processNow )
{
bufferSwitch( index, processNow );
return 0L;
}

bool RtApiAsio :: probeDeviceOpen( unsigned int deviceId, StreamMode mode, unsigned int channels,
unsigned int firstChannel, unsigned int sampleRate,
RtAudioFormat format, unsigned int *bufferSize,
Expand Down Expand Up @@ -3825,7 +3837,7 @@ bool RtApiAsio :: probeDeviceOpen( unsigned int deviceId, StreamMode mode, unsig
asioCallbacks.bufferSwitch = &bufferSwitch;
asioCallbacks.sampleRateDidChange = &sampleRateChanged;
asioCallbacks.asioMessage = &asioMessages;
asioCallbacks.bufferSwitchTimeInfo = NULL;
asioCallbacks.bufferSwitchTimeInfo = &bufferSwitchTimeInfo;
result = ASIOCreateBuffers( handle->bufferInfos, nChannels, stream_.bufferSize, &asioCallbacks );
if ( result != ASE_OK ) {
// Standard method failed. This can happen with strict/misbehaving drivers that return valid buffer size ranges
Expand Down
Loading