Skip to content

fix: encode Windows CWD paths for web routes - #40

Merged
lroolle merged 1 commit into
thevibeworks:mainfrom
creamtea47:fix/windows-cwd-web-route
Sep 2, 2026
Merged

fix: encode Windows CWD paths for web routes#40
lroolle merged 1 commit into
thevibeworks:mainfrom
creamtea47:fix/windows-cwd-web-route

Conversation

@creamtea47

Copy link
Copy Markdown
Contributor

Summary

  • encode Windows backslashes in Codex CWD project identifiers
  • keep generated web session links to one route segment
  • cover a Windows CWD in the existing TestEncodePath table

Validation

  • go test ./internal/parser -run '^TestEncodePath$'
  • opened a real Windows Codex session at the generated route and received HTTP 200

@lroolle lroolle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: go test ./internal/parser green in CI, and the change is the minimal one. DecodePath stays lossy for Windows paths, but it already was for / (see the note in internal/provider/multi.go), and the route now resolves. Thanks for the fix and the test case.

@lroolle
lroolle merged commit 7bd6da3 into thevibeworks:main Sep 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants