fix(ci): move SHOPBOT_DATA_DIR to step scope so the workflow compiles - #13
Merged
Conversation
The `runner` context is not available in job-level `env:` -- it only exists
inside steps. Referencing ${{ runner.temp }} there makes the whole workflow
fail to compile: the run is marked failed immediately with zero jobs
scheduled and no annotations, which reads like a flaky runner rather than a
syntax error.
CI has therefore never once passed: 81 runs, 81 failures, back to the
workflow's introduction in 0e0e43f (2026-06-04), the only commit that has
ever touched this file. Milestones v2.0 through v4.2 were audited as
"CI-green" against a CI that had never compiled.
Moving the variable onto the Test step is the minimal fix and preserves the
original intent of keeping path resolution off the runner home dir.
With the compile error fixed, the workflow finally scheduled jobs and both runners died the same way: "pytest: command not found" (exit 127 on ubuntu, exit 1 on windows). Cause: the Install step ran only `pip install -e .[web]`, and pyproject's [project.dependencies] declares just platformdirs. Every real dependency -- pydantic, nodriver, keyring, cryptography, pygame, and pytest itself -- lives in requirements.txt, which CI never installed. So CI could not have run a single test even with a compiling workflow. Also adds httpx==0.28.1 to requirements.txt. fastapi's TestClient needs it and it was undeclared everywhere, so a fresh checkout could not run the web tests either. 0.28.1 is the version already proven locally.
Owner
Author
Green. First time, on run 82.Both fixes were load-bearing, and they failed in sequence:
So a compiling workflow alone would still have run zero tests. Both had to go. Worth noting the counts: identical on Ubuntu and Windows, and identical to the local Windows baseline. The suite had only ever been run on one developer's machine, and it turns out to be genuinely cross-platform clean. That was not guaranteed going in; it is the answer this PR existed to produce.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.