fix: add input validation to prevent errors in calculator#1240
Closed
Suraj-H675 wants to merge 1 commit into
Closed
fix: add input validation to prevent errors in calculator#1240Suraj-H675 wants to merge 1 commit into
Suraj-H675 wants to merge 1 commit into
Conversation
Prevents division by zero, multiple decimal points, and consecutive operators. - Added hasDecimalInCurrentNumber() validation - Added hasConsecutiveOperators() validation - Modified NumberButtonClick() and functionButton() with validation Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
Prevents errors when using the calculator - blocks division by zero, multiple decimal points, and consecutive operators.
What changed and why?
hasDecimalInCurrentNumber()to detect decimal points in the current numberhasConsecutiveOperators()to detect consecutive operator pressesNumberButtonClick()to prevent/0, multiple decimals, and consecutive operatorsfunctionButton()to validate expressions before evaluationHow was this tested?
Manual testing of all validation cases:
5/0shows error alert5..3shows error alert5++3replaces consecutive operatorChecklist
This contribution was created with AI assistance, with human review and approval at each step.