Aggregate same-series counters in Analytics Engine sink - #198
Open
kanwarbajwa wants to merge 1 commit into
Open
Conversation
Analytics Engine allows at most 25 writeDataPoint calls per Worker invocation. Per-event counters (one increment per upstream stream message) produced hundreds of observations in a single flush, so writes past the cap threw and were dropped (~10-15% undercount on ts_mcp_upstream_stream_messages_total, occasionally clipping tool metrics flushed in the same invocation). Sum counter observations sharing a series (name + labels) into one data point before writing. Histograms and gauges keep one point per observation.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analytics Engine allows at most 25 writeDataPoint calls per Worker invocation. Per-event counters (one increment per upstream stream message) produced hundreds of observations in a single flush, so writes past the cap threw and were dropped (~10-15% undercount on ts_mcp_upstream_stream_messages_total, occasionally clipping tool metrics flushed in the same invocation).
Sum counter observations sharing a series (name + labels) into one data point before writing. Histograms and gauges keep one point per observation.