Add raw Spotter output mode behind a flag - #200
Merged
Conversation
Rifdhan
commented
Aug 6, 2026
Rifdhan
commented
Collaborator
- Client can specify via URL flag if they want the full raw Spotter output instead of the simplified version we are providing
- Pass along the unmodified Spotter event stream if this flag has been set
- No impact when using v1 tools, this is only for v2 tools
- Update tests and add coverage
- Client can specify via URL flag if they want the full raw Spotter output instead of the simplified version we are providing - Pass along the unmodified Spotter event stream if this flag has been set - No impact when using v1 tools, this is only for v2 tools - Update tests and add coverage
Collaborator
Author
|
@copilot review this change. Make suggestions or identify any gaps but don't make any code changes yourself. |
Contributor
A couple of gaps I’d call out from the review:
|
| }, | ||
| }, | ||
| { | ||
| ...GET_SESSION_UPDATES_BASE_TOOL_DEFINITION, |
Collaborator
There was a problem hiding this comment.
description is same for both
1. Synthesize answer_id on RAW answer events, so the get_session_updates -> create_dashboard handoff keeps working when enable-raw-session-updates is on (callCreateDashboard unconditionally JSON.parses answer_id). 2. Split the get_session_updates tool description into structured vs raw variants instead of sharing one description across both output schemas; the raw description now reflects the unfiltered z.unknown() contract instead of promising complete/filtered results. 3. Raw mode now still classifies each event by type to record recordUpstreamStreamMessageMetric counts and flag span errors on upstream error events, closing the observability blind spot where raw-mode metrics/error spans went dark. Messages are still passed through unmodified otherwise. 4. Widen Message[] to (Message | RawMessage)[] through the streaming-utils -> thoughtspot-service -> storage-service -> conversation-storage-server chain, since raw mode's pass-through items are not guaranteed to match the Message shape. Updated test/streaming-utils.spec.ts to match the new raw-mode behavior for answer_id synthesis, error observability, and metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.