Skip to content

SCAL-325090 Add PreRenderConfig to control iframe z-index - #603

Open
shivam-kumar-ts wants to merge 3 commits into
mainfrom
SCAL-325090
Open

SCAL-325090 Add PreRenderConfig to control iframe z-index#603
shivam-kumar-ts wants to merge 3 commits into
mainfrom
SCAL-325090

Conversation

@shivam-kumar-ts

@shivam-kumar-ts shivam-kumar-ts commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Introduces PreRenderConfig interface and preRenderConfig property on BaseViewConfig to group all pre-render settings into a single config object
Adds zIndex to control the hidden wrapper's CSS z-index (default -1000), fixing cases where the hidden pre-render bleeds above other page content in shallow stacking contexts
Migrates preRenderId, preRenderContainer, and doNotTrackPreRenderSize into PreRenderConfig for backward compatibility — preRenderConfig.* takes precedence when both are set, existing top-level usage continues to work unchanged
Adds @default tags and fixes tag ordering on all preRender-related JSDoc in BaseViewConfig

@shivam-kumar-ts
shivam-kumar-ts requested a review from a team as a code owner July 29, 2026 08:50
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@603

commit: 1ebece3

@shivam-kumar-ts shivam-kumar-ts changed the title SCAL-325090 Add PreRenderConfig to control iframe z-index and hide styles SCAL-325090 Add PreRenderConfig to control iframe z-index Jul 31, 2026
Comment thread src/embed/liveboard.ts Outdated
Comment thread src/embed/liveboard.ts Outdated
Comment thread src/embed/ts-embed.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants