Remove retired KEEP legacy surfaces#3947
Open
mswilkison wants to merge 2 commits intomainfrom
Open
Conversation
Add explicit cancelled-stake guard to TopUps.instantComplete and TopUps.initiate. Previously, TokenStakingEscrow.hasDeposit guarded against this for grant-backed stakes; removing the escrow left a path where cancelStake (which zeroes amount but preserves createdAt) allowed the same owner to top-up the same operator back into an active state. Also remove stale "for escrow" from GrantStaking NatSpec and clarify that the committed mainnet private key in retired-components.md has been rotated. Regression tests added for both code paths (instantComplete and initiate) in TestTokenStake.js. Add .ubsignore to exclude test directories from UBS null-guard checks; Chai assertion chains (.to.eq.BN) are intentionally unguarded in tests.
piotr-roslaniec
approved these changes
May 5, 2026
Collaborator
piotr-roslaniec
left a comment
piotr-roslaniec
left a comment
There was a problem hiding this comment.
Reviewed and addressed findings: cancelled-operator resurrection guard restored in TopUps, stale NatSpec updated, private key note clarified. Regression tests added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Notes